Merged
Conversation
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
landonxjames
approved these changes
Oct 2, 2025
Contributor
landonxjames
left a comment
landonxjames
left a comment
There was a problem hiding this comment.
Semver failure is expected with the model change, everything else looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Upgrades Smithy to 1.62.0
Description
With Smithy 1.62.0, we need to use the updated partitions file. As a result, we updated service models in this repository (copied them over from
aws-sdk-rust/aws-models).Two unicode substring tests failed upstream, within the Smithy team itself, as part of 1.62.0. The team deleted them with the intention that they will add new ones to the public repo, so we manually replicated the deletion in
substring.smithy(maybe we don't have to keep a local copy ofcodegen-client/src/test/resources/META-INF/smithy/endpoint-testsonce tests are added to public Smithy repo).Testing
We should be able to ignore semver compliance check since it's comparing the ec2 crate from the old model against that from the updated model; the one from the updated model is already out in the wild on crates.io
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.