Replace doc_auto_cfg with doc_cfg to allow docsrs build to succeed#4331
Merged
aws-sdk-rust-ci merged 3 commits intomainfrom Oct 6, 2025
Merged
Replace doc_auto_cfg with doc_cfg to allow docsrs build to succeed#4331aws-sdk-rust-ci merged 3 commits intomainfrom
doc_auto_cfg with doc_cfg to allow docsrs build to succeed#4331aws-sdk-rust-ci merged 3 commits intomainfrom
Conversation
See rust-lang/rust#138907 for reference And https://docs.rs/crate/aws-sdk-dynamodb/1.94.0/builds/2555063 for an example of how builds were failing
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
approved these changes
Oct 4, 2025
1 task
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Our docrs builds started failing recently with the error:
The linked issue shows that
doc_auto_cfghas recently been merged intodoc_cfg. docsrs builds with the latest nightly toolchain, so the change has impacted our doc builds. This PR makes that change in codegen and in all of our runtime crates.Checklist
.changelogdirectory, specifying "client," "server," or both in theapplies_tokey..changelogdirectory, specifying "aws-sdk-rust" in theapplies_tokey.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.