fix: builder accessor method naming conflicts#4342
Open
nated0g wants to merge 10 commits intosmithy-lang:mainfrom
Open
fix: builder accessor method naming conflicts#4342nated0g wants to merge 10 commits intosmithy-lang:mainfrom
nated0g wants to merge 10 commits intosmithy-lang:mainfrom
Conversation
The setterName() extension function now requires a symbolProvider parameter. Updated call sites to pass the correct symbolProvider.
Verifies that structures with a 'meta' field get properly renamed to 'meta_value' with corresponding setter/getter methods to avoid conflicts with error metadata fields.
Use setterName() extension function instead of manually constructing setter names to handle field renaming (e.g. default -> default_value).
nated0g
changed the title
landonxjames
approved these changes
Oct 13, 2025
Contributor
landonxjames
left a comment
landonxjames
left a comment
There was a problem hiding this comment.
Assuming that commit I did for the ktlint issues works this all looks good to me. Will require a review from the server team as well.
2 tasks
rcoh
approved these changes
Oct 14, 2025
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Collaborator
|
I think this will probably cause breaking changes because setters that almost certainly exist in the wild for fields like I think we need to make this context aware so that we only rename setters where the setter itself would actually conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#4338
Description
fixes a couple stray compilation errors in @haydenbaker's PR (#4341), and adds a test, adds changelog entry
Testing
Added a test in
FluentClientGeneratorTest.ktto verify the bug no longer existsChecklist
.changelogdirectory, specifying "client," "server," or both in theapplies_tokey.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.