Add server support for initial-request messages#4344
Merged
Conversation
rcoh
force-pushed
the
fix-initial-request
branch
from
f02f118 to
6238efa
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
aajtodd
approved these changes
Oct 13, 2025
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
force-pushed
the
fix-initial-request
branch
from
7fe2c8e to
a1c6f82
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
This adds support for `initial-request` event stream messages on the server and fixes #4325. This support is complete (in that it handles both empty and non-empty initial requests and is backwards compatible with clients that do not send initial requests when not required. BUT: it is not complete in that the errors it sends when the initial request are invalid will not easily make it back to clients. (#4343) The error needs to be sent over the event-stream, but the current design of the traits in aws-smithy-http-server do not allow opening the event stream in this context.
rcoh
force-pushed
the
fix-initial-request
branch
from
a1c6f82 to
eb31a32
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jasgin
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#4325: Properly handle initial requests for servers
Fixes: #4235
Description
This adds support for
initial-requestevent stream messages on the server and fixes #4325.This support is complete (in that it handles both empty and non-empty initial requests and is backwards compatible with clients that do not send initial requests when not required.
BUT: it is not complete in that the errors it sends when the initial request are invalid will not easily make it back to clients. (#4343)
The error needs to be sent over the event-stream, but the current design of the traits in aws-smithy-http-server do not allow opening the event stream in this context.
Testing
Built on the test suite created earlier to test all different cases of event stream error handling.
Checklist
.changelogdirectory, specifying "client," "server," or both in theapplies_tokey..changelogdirectory, specifying "aws-sdk-rust" in theapplies_tokey.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.