Fix bug where queryParams was ignored if there were no other params#4346
Merged
Fix bug where queryParams was ignored if there were no other params#4346
Conversation
rcoh
force-pushed
the
fix-map-query-params
branch
from
53d461d to
80cb631
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
approved these changes
Oct 10, 2025
gradle.properties
Outdated
| isTestingEnabled=true | ||
| # codegen publication version | ||
| codegenVersion=0.1.4 | ||
| codegenVersion=0.1.5 |
Contributor
There was a problem hiding this comment.
We can keep 0.1.4, since the most recent release is 0.1.3 (hope CI will pass with 0.1.4)
rcoh
commented
Oct 10, 2025
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
force-pushed
the
fix-map-query-params
branch
from
f05e4aa to
bf7f54e
Compare
jasgin
approved these changes
Oct 13, 2025
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
There was an ancient bug where requests
@httpQueryParamswas ignored if no other query params were set.Description
Fix buggy short-circuit so that query param logic was generated.
Testing
Checklist
.changelogdirectory, specifying "client," "server," or both in theapplies_tokey..changelogdirectory, specifying "aws-sdk-rust" in theapplies_tokey.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.