Fix deprecated as_slice() calls in aws-smithy-checksums#4347
Merged
Conversation
Replace deprecated as_slice() method calls with as_ref() to resolve deprecation warnings from generic-array upgrade. This affects SHA1, SHA256, and MD5 checksum implementations. Fixes compilation warnings: - error: use of deprecated method GenericArray::as_slice - help: please upgrade to generic-array 1.x Bumps version from 0.63.9 to 0.63.10.
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
aajtodd
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR fixes deprecation warnings from the generic-array crate upgrade by replacing deprecated
as_slice()method calls withas_ref().Description
as_slice()withas_ref()in SHA1, SHA256, and MD5 checksum implementationsTesting
cargo checkpassescargo testpasses (all 20 tests)Checklist
Cargo.tomlif I made changes to dependenciescargo testlocally and it passescargo clippylocally and it passesFixes the following compilation warnings: