Fix missing Kotlin stdlib versions in published POMs#4386
Open
Fix missing Kotlin stdlib versions in published POMs#4386
Conversation
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jasgin
approved these changes
Nov 6, 2025
aajtodd
approved these changes
Nov 6, 2025
Contributor
aajtodd
left a comment
There was a problem hiding this comment.
Odd that this is even necessary but seems ok.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Published Maven POMs were missing explicit version declarations for Kotlin stdlib dependencies (e.g., kotlin-stdlib-jdk8), causing dependency resolution issues for consumers of these artifacts.
Solution
This PR adds explicit version management for Kotlin stdlib dependencies in two places:
Resolution Strategy (smithy-rs.kotlin-conventions.gradle.kts):
POM Version Mapping (smithy-rs.publishing-conventions.gradle.kts):
Testing