Open
Conversation
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
reviewed
Dec 5, 2025
Contributor
ysaito1001
left a comment
There was a problem hiding this comment.
Looks good, as it did already in the design. A separate crate doesn't look bad at all. Might be worth running this change through catapult with dev account if we want to be sure.
638f41c to
0f697fe
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
0f697fe to
bd15968
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Implement SigningError enum with four variants for different error scenarios: InvalidKey, InvalidPolicy, InvalidInput, and SigningFailure. Each variant contains descriptive error messages for debugging. - Add src/error.rs with SigningError enum marked #[non_exhaustive] - Implement std::error::Error and Display traits - Add comprehensive unit tests for all error variants - Integrate error module into lib.rs 🤖 Assisted by [Amazon Q Developer](https://aws.amazon.com/q/developer)
eaee58a to
90224ed
Compare
landonxjames
approved these changes
Jan 8, 2026
Contributor
landonxjames
left a comment
There was a problem hiding this comment.
LGTM. Probably still want to wait for Cloudfront feedback and final approval on the SEP before actually merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Implements CloudFront signed URL and signed cookie generation for private content access control (see CloudFront developer guide), addressing #255.
Overview
This PR adds a new
aws-sdk-cloudfront-signercrate that provides cryptographic signing capabilities for CloudFront URLs and cookies. CloudFront signed URLs/cookies enable time-limited, policy-based access control to private CloudFront distributions using
RSA-SHA1orECDSA-SHA1signatures.Key Features
API Design
Implementation Details
Feature Flags
Testing
Checklist
.changelogdirectory, specifying "client," "server," or both in theapplies_tokey..changelogdirectory, specifying "aws-sdk-rust" in theapplies_tokey.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.