test: Add enum edge cases to naming obstacle course#4482
Open
udayprakash wants to merge 2 commits intosmithy-lang:mainfrom
Open
test: Add enum edge cases to naming obstacle course#4482udayprakash wants to merge 2 commits intosmithy-lang:mainfrom
udayprakash wants to merge 2 commits intosmithy-lang:mainfrom
Conversation
Add test cases for enum-related codegen issues: - SpecialCharacterEnum: Enum values containing # characters that conflict with rustTemplate formatting (see PR smithy-lang#4476) - UnnamedEnum: Unnamed enums that need AsRef<str> implementation (see issue smithy-lang#3886, PR smithy-lang#4478) These tests currently fail, demonstrating the bugs that need to be fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Add test cases to the naming obstacle course for enum-related codegen issues that have been identified.
Description
Adds two new enum types to
naming-obstacle-course-ops.smithy:SpecialCharacterEnum- Enum values containing#characters that conflict with rustTemplate formattingUnnamedEnum- Unnamed enums (values without names) that needAsRef<str>implementationTesting
These tests currently fail by design - they demonstrate the bugs that need to be fixed by the related PRs.
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.