Fix: validate body contents for empty operation input across protocols(issue 3723)#4522
Open
lee-1104 wants to merge 2 commits intosmithy-lang:mainfrom
Open
Fix: validate body contents for empty operation input across protocols(issue 3723)#4522lee-1104 wants to merge 2 commits intosmithy-lang:mainfrom
lee-1104 wants to merge 2 commits intosmithy-lang:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this is my first contribution to smithy-rs. Happy to address any feedback!
Motivation and Context
fixes #3723
When an operation has empty or no modeled input, the server was not validating the request body contents. This allowed malformed requests to be silently accepted.
Description
Added body validation in ServerHttpBoundProtocolGenerator for operations with empty or no input:
AdditionalTokensEmptyStructfrom the failing test list since it now passes.Testing
./gradlew codegen-server-test:assemblecompletes successfullyChecklist
.changelogdirectory, specifying "client," "server," or both in theapplies_tokey.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.