Merged
Conversation
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
### Summary - Add missing From<DateTime> for aws_smithy_types::DateTime impl in the Python server runtime, consistent with the existing Blob pattern - Add .into() call for TimestampShape in EventStreamMarshallerGenerator.headerValue(), consistent with how BlobShape and StringShape already handle conversions ### Motivation The Python server codegen generates `HeaderValue::Timestamp(value)` where value is the Python wrapper `DateTime (aws_smithy_http_server_python::types::DateTime)`, but `HeaderValue::Timestamp` expects `aws_smithy_types::DateTime`. Other wrapper types (e.g. Blob) already work because the codegen emits `.into_inner().into()`. The `DateTime` case was missed. For non-Python targets, `.into()` on `aws_smithy_types::DateTime` is a no-op via Rust's blanket `impl<T> From<T> for T`. --------- Co-authored-by: Fahad Zubair <fahadzub@amazon.com> Co-authored-by: ysaito1001 <awsaito@amazon.com>
landonxjames
approved these changes
Feb 16, 2026
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
drganjoo
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
P382257849
Description
Changes on the client side:
SmithyTypesPubUseExtraTest.ktthat would otherwise defeat the purpose of the testChanges on the server side:
smithy.framework#ValidationExceptionto constrained operations #4506)Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.