Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,12 @@ class HttpBoundProtocolPayloadGenerator(
// need to take ownership.
return if (payloadMemberName == null) {
ProtocolPayloadGenerator.PayloadMetadata(takesOwnership = false)
} else if (operationShape.isInputEventStream(model)) {
} else if (
when (httpMessageType) {
HttpMessageType.REQUEST -> operationShape.isInputEventStream(model)
HttpMessageType.RESPONSE -> operationShape.isOutputEventStream(model)
}
) {
ProtocolPayloadGenerator.PayloadMetadata(takesOwnership = true)
} else {
val member = shape.expectMember(payloadMemberName)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,25 @@ class EventStreamUnmarshallerGenerator(
}
}
}
// Handle implicit payload members: members with neither @eventPayload nor @eventHeader.
// Per the Smithy spec, these are collectively serialized as a protocol-specific document
// in the message body.
val implicitMembers = unionStruct.members().filter {
!it.hasTrait<EventPayloadTrait>() && !it.hasTrait<EventHeaderTrait>()
}
if (implicitMembers.isNotEmpty() && payloadMember == null) {
val parser = protocol.structuredDataParser().errorParser(unionStruct)
if (parser != null) {
rustTemplate(
"""
builder = #{parser}(&message.payload()[..], builder)
.map_err(|err| #{Error}::unmarshalling(format!("failed to unmarshall: {err}")))?;
""",
"parser" to parser,
*codegenScope,
)
}
}
rustTemplate(
"Ok(#{UnmarshalledMessage}::Event(#{Output}::$unionMemberName(builder.build())))",
"Output" to unionSymbol,
Expand Down
Loading