Add schema serde related types#4536
Merged
landonxjames merged 7 commits intofeature/schemafrom Feb 26, 2026
Merged
Conversation
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
landonxjames
commented
Feb 16, 2026
ysaito1001
approved these changes
Feb 19, 2026
Contributor
ysaito1001
left a comment
ysaito1001
left a comment
There was a problem hiding this comment.
Good start to build on. Left some minor comments, but overall I see reasonable alignment between the design and its implementation in code.
landonxjames
commented
Feb 20, 2026
Add aws-smithy-schema to CrateSet
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
First pass of the Rust types needed for schema based serde. This will definitely be refined as the work continues, but wanted to get these out for review early to see if anyone can find any issue with these.
Testing
Added tests of simple mock impls of the major traits.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.