Add improvements to default server metrics#4548
Conversation
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jlizen
left a comment
jlizen
left a comment
There was a problem hiding this comment.
I think probably we want to flip to bool?
What do you think about publishing eg success == false?
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jasgin
force-pushed
the
add-success-metric
branch
from
c8dd794 to
9a692ca
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jlizen
left a comment
jlizen
left a comment
There was a problem hiding this comment.
Looks good, though list of metrics might need tweaking.
| pub(crate) error: Option<u64>, | ||
| /// Server fault indicator (1 if 5xx status code, 0 otherwise) | ||
| pub(crate) fault: Option<u64>, | ||
| pub(crate) client_error: Option<bool>, |
There was a problem hiding this comment.
good breakdown. and then, success lets you average across client/server/redirect by finding 0s
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jasgin
changed the title
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
3 participants
Motivation and Context
Description
Add success metric to default server metrics, align naming, add method for disabling outstanding_requests metric.
Testing
Checklist
.changelogdirectory, specifying "client," "server," or both in theapplies_tokey..changelogdirectory, specifying "aws-sdk-rust" in theapplies_tokey.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.