Conversation
| ASYNC_EXPIRATION_LENGTH = 600 # 10 minutes | ||
|
|
||
| def initialize | ||
| def initialize(_options = {}) |
There was a problem hiding this comment.
Why is the options parameter added back into the method header?
There was a problem hiding this comment.
I suppose this is not necessary right now, but I may want to add back the before refresh callback. Is there a use case maybe with token file reading in SSO?
There was a problem hiding this comment.
I do see that in v3 we have the before_refresh option in certain providers and @before_refresh member in the RefreshingCredentials, but I don't immediately see where this is used in the SDK code. Going through the default chain at least I don't think we use before_refresh for SSOCredentials. What use case were you thinking of?
There was a problem hiding this comment.
It's used by customers. My thought was we can make it a list of callbacks and not just one proc, then we can register a default one that also reread the token file instead of building it into refresh, but I don't know if we care to do that. It was just a thought.
gems/smithy-client/spec/smithy-client/plugins/resolve_auth_spec.rb
Outdated
Show resolved
Hide resolved
richardwang1124
left a comment
There was a problem hiding this comment.
I think it looks good overall and changes to V4 are minor. Let me know if you end up keeping the options in the RefreshingIdentityProvider initializer.
Rework of identity and credentials to be more like SDK v3.
Major changes: