chore: Update CI latests, extend timeout#1032
Conversation
| - name: Build & Run smithy-swift Kotlin Unit Tests | ||
| run: ./gradlew build | ||
| - name: Build & Run smithy-swift Swift Unit Tests | ||
| timeout-minutes: 15 |
There was a problem hiding this comment.
Not needed, not sure how this limit originated.
There was a problem hiding this comment.
Isn't a timeout normally needed in circumstances that the unit tests continues longer than expected or needed?
There was a problem hiding this comment.
There is a default timeout of six hours that applies if none is specified. This seems to be the only place we specify an explicit timeout, so we're already using the six hour timeout on every other test step. I'm not worried about hitting this number because our test suite has no history of freezing up.
Our issue is that we have builds that would have finished successfully, but they're just taking longer than the 15 minute timeout, so they're getting killed before they can succeed.
3 participants
Description of changes
apple-cibuilds; it seems to be stopping builds that have not hung or failedScope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.