fix: Fix MD5 middleware codegen & runtime code to match spec#885
Merged
fix: Fix MD5 middleware codegen & runtime code to match spec#885
Conversation
… hash calculation critera in runtime code.
dayaffe
approved these changes
Dec 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corresponding PR: awslabs/aws-sdk-swift#1803
Issue #
1516
Description of changes
ContentMD5Middlewareand runtime criteria inContentMD5Middlewarefor MD5 hash calculation to match spec. MD5 will be phased out by flexible checksum in the future.Content-MD5headers, they can still provide it as input members. It will then be serialized in to the request automatically. What the change in this PR does is effectively turning off SDK from automatically calculating the MD5 checksum for users and instead using flexible checksums behind the scenes.Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.