fix: Sort package manifest dependencies for more deterministic lists#891
Merged
fix: Sort package manifest dependencies for more deterministic lists#891
Conversation
sichanyoo
approved these changes
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Package manifest dependencies are sorted by "target" instead of package name so that lists are more deterministic. (Package name on a SymbolDependency can, in some cases, be the Swift package that encloses a target; this means many targets in smithy-swift will have indeterminate sort order when sorted by package name.)
Also: a little code cleanup.
Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.