fix(core): skip assigning undefined for absent response body fields#1871
Merged
fix(core): skip assigning undefined for absent response body fields#1871
Conversation
kuhe
reviewed
Feb 16, 2026
smilkuri
force-pushed
the
fix/httpbinding
branch
from
2eb4d55 to
9662f55
Compare
smilkuri
force-pushed
the
fix/httpbinding
branch
from
9662f55 to
b2a0c24
Compare
kuhe
reviewed
Feb 16, 2026
packages/core/src/submodules/protocols/HttpBindingProtocol.spec.ts
Outdated
Show resolved
Hide resolved
kuhe
reviewed
Feb 16, 2026
packages/core/src/submodules/protocols/HttpBindingProtocol.spec.ts
Outdated
Show resolved
Hide resolved
kuhe
approved these changes
Feb 16, 2026
smilkuri
force-pushed
the
fix/httpbinding
branch
from
eab0d00 to
444dfb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
P383491202
Description of changes:
After schema-serde was enabled in v3.930.0, fields absent from the HTTP response body are being set to undefined on the output object. The root cause is the copy loop in
deserializeResponsewas iterating through all schema-definednonHttpBindingMembersand assigning undefined for the fields that were absent.If one or more of the packages in the
/packagesdirectory has been modified, be sureyarn changeset addhas been run and its output hasbeen committed and included in this pull request. See CONTRIBUTING.md.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.