fix(util-stream): warn when buffered readable encounters mixed Buffer/Uint8Array chunks#1881
Open
TrevorBurnham wants to merge 1 commit intosmithy-lang:mainfrom
Open
Conversation
…/Uint8Array chunks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Resolves #1553
Description of changes:
When a stream mixes
Uint8ArrayandBufferchunk types,createBufferedReadableflushes its internal buffer on every type switch regardless of size. This can produce undersized chunks that downstream consumers (like S3's chunked upload) reject withInvalidChunkSizeError, which is confusing when the user has explicitly setrequestStreamBufferSize.This change adds a
logger.warn()when the buffering logic detects a switch betweenBuffer(mode 2) andUint8Array(mode 1) chunks, in both the NodeReadableandReadableStreamcode paths. The warning explains the cause and tells the user to normalize their stream to a consistent chunk type.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.