Removing appliesTo from NullAndEmptyHeaders tests #2438
Open
landonxjames wants to merge 1 commit intosmithy-lang:mainfrom
Open
Removing appliesTo from NullAndEmptyHeaders tests #2438landonxjames wants to merge 1 commit intosmithy-lang:mainfrom
appliesTo from NullAndEmptyHeaders tests #2438landonxjames wants to merge 1 commit intosmithy-lang:mainfrom
Conversation
landonxjames
force-pushed
the
landonxjames/serveremptyheaders
branch
from
640aa0d to
b2cb5ec
Compare
milesziemer
requested changes
Dec 10, 2024
Contributor
There was a problem hiding this comment.
Since these two operations and their tests (NullAndEmptyHeaders(Client/Server)) are now identical, can we just combine them into one and get rid of the client-only/server-only tags? For restXml too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Removing
appliesTofromNullAndEmptyHeaderstests per conversation with @kstich. Follow up to UpdateNullAndEmptyHeadersServertests forrestJson1andrestXml#2433Testing
Links
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.