Skip to content

Add flattenAndRemoveMixins build transform#2516

Merged
kstich merged 1 commit intomainfrom
add_flatten_and_remove_mixins_build_transform
Feb 13, 2025
Merged

Add flattenAndRemoveMixins build transform#2516
kstich merged 1 commit intomainfrom
add_flatten_and_remove_mixins_build_transform

Conversation

@kstich
Copy link
Contributor

@kstich kstich commented Feb 12, 2025

Background

Adds a missing build transform for this model transform.

Links

Resolves #2515


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kstich kstich requested a review from a team as a code owner February 12, 2025 18:34
@kstich kstich requested a review from yefrig February 12, 2025 18:34
/**
* {@code flattenAndRemoveMixins} flattens mixins out of the model.
*/
public final class FlattenAndRemoveMixins implements ProjectionTransformer {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: doesn't flatten=removing for mixings? if not, then naming seems ok

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm I see the transformer uses that name

@kstich kstich merged commit 8af6d08 into main Feb 13, 2025
8 checks passed
@kstich kstich deleted the add_flatten_and_remove_mixins_build_transform branch February 13, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support "flatten" transform for mixins

2 participants