Skip to content

Fix resource identifier binding validation#2526

Merged
kstich merged 1 commit intomainfrom
fix_identifier_binding_validator
Feb 18, 2025
Merged

Fix resource identifier binding validation#2526
kstich merged 1 commit intomainfrom
fix_identifier_binding_validator

Conversation

@kstich
Copy link
Contributor

@kstich kstich commented Feb 18, 2025

This commit fixes a bug where only the names of identifiers were validated, not the ShapeId that represent them, when testing the binding of operations to resources.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This commit fixes a bug where only the names of identifiers were
validated, not the ShapeId that represent them, when testing the
binding of operations to resources.
@kstich kstich requested a review from a team as a code owner February 18, 2025 06:34
@kstich kstich requested review from JordonPhillips and yasmewad and removed request for yasmewad February 18, 2025 06:34
@kstich kstich merged commit 5f89b6d into main Feb 18, 2025
8 checks passed
@kstich kstich deleted the fix_identifier_binding_validator branch February 18, 2025 18:40
@mcmasn-amzn
Copy link
Contributor

I think this broke one of my models. Is there a way to model an API which accept a single string field which can be one of multiple ways to identify a resource? Example -- I have an API that is similar to lambda:GetFunction, which accepts have multiple name formats (full arn or name or partial arn), but only one is considered the true, full identifier in the resource model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants