Use ShapeId instead of name in OAS conversion#2560
Merged
Conversation
This path previously created a bunch of extra ShapeId garbage from converting strings into ShapeIds each time a test was performed. The ShapeId instances for these already exist, so we use those instead.
sugmanue
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This path previously created a bunch of extra
ShapeIdgarbage from convertingStrings intoShapeIds each time a test was performed. TheShapeIdinstances for these already exist, so we use those instead.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.