Add additional properties to OpenApiConfig#2705
Add additional properties to OpenApiConfig#2705msosnicki wants to merge 3 commits intosmithy-lang:mainfrom
Conversation
| * Sets additional non-standard config properties that might be used by other components | ||
| * @param additionalProperties Map of additional properties | ||
| */ | ||
| public void setAdditionalProperties(Map<String, String> additionalProperties) { |
There was a problem hiding this comment.
suggestion: shall we have a method to just put into the properties, without having to pass the entire map?
i.e. void putAdditionalProperty(String key, String value)
There was a problem hiding this comment.
also, looks like ModelAssembler allows Object values so maybe we should be as flexible here as well. String is fairly limiting, after all.
There was a problem hiding this comment.
Yeah, makes sense, changed so it resembles how it's done in ModelAssembler
|
Is the behavior you're looking for already filled by the |
Sorry for late reply, the extension mechanism is exactly what is needed, thanks! |
Background
JsonSchemaMapperandOpenApiMapperhave access toOpenApiConfig. In some cases (see related smithy4s PR), there is a need to pass additional information to such mappers. This PR addsMap<String, String> additionalPropertiesfield to enable thatBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.