Skip to content

Fix using shapes without TaritDefinition as trait#2733

Merged
joewyz merged 2 commits intomainfrom
joewyz/fix-everything-can-be-trait
Aug 11, 2025
Merged

Fix using shapes without TaritDefinition as trait#2733
joewyz merged 2 commits intomainfrom
joewyz/fix-everything-can-be-trait

Conversation

@joewyz
Copy link
Contributor

@joewyz joewyz commented Aug 7, 2025

Background

Currently smithy model just validates if the trait is defined in the model so that any shape defined can be used as trait.

An example model would look like this:

$version: "2"

namespace test

document Foo

@Foo(name: "aa")
structure Bar {}

This PR will fix #2725


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@joewyz joewyz requested a review from a team as a code owner August 7, 2025 23:13
@joewyz joewyz requested a review from JordonPhillips August 7, 2025 23:13
@joewyz joewyz merged commit 85d46aa into main Aug 11, 2025
9 checks passed
@joewyz joewyz deleted the joewyz/fix-everything-can-be-trait branch August 11, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Anything can be a trait

2 participants