Return contained operations/resources in order#2746
Merged
JordonPhillips merged 2 commits intomainfrom Oct 27, 2025
Merged
Conversation
JordonPhillips
force-pushed
the
tree-operations
branch
2 times, most recently
from
183045b to
ddcf972
Compare
This updates the results of TopDownIndex to be in modeled order. Previously the resuls were being sorted. This problem extended to the Walker, which was returning shapes in reverse order.
JordonPhillips
force-pushed
the
tree-operations
branch
from
ddcf972 to
2082f48
Compare
kstich
approved these changes
Oct 24, 2025
smithy-model/src/main/java/software/amazon/smithy/model/neighbor/Walker.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Kevin Stich <kevin@kstich.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the results of TopDownIndex to be in modeled order. Previously the resuls were being sorted. This problem extended to the Walker, which was returning shapes in reverse order.
This fixes #2699
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.