Skip to content

Raise the severity for query error validator to danger #2758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sugmanue merged 1 commit into from
Aug 26, 2025
Merged

Raise the severity for query error validator to danger #2758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ts/src/main/java/software/amazon/smithy/aws/traits/protocols/QueryErrorCodeValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
import software.amazon.smithy.utils.SmithyInternalApi;

/**
* Emits a warning if two or more error shapes share the same error code.
* Emits a danger if two or more error shapes share the same error code.
*/
@SmithyInternalApi
public class QueryErrorCodeValidator extends AbstractValidator {
Expand Down Expand Up @@ -73,7 +73,7 @@ private List<ValidationEvent> validateService(Model model, ServiceShape service)
if (events.isEmpty()) {
events = new ArrayList<>();
}
events.add(warning(service,
events.add(danger(service,
String.format("Multiple error shapes with the error code `%s` found: [%s]. This error code "
+ "ambiguity will result in the wrong error shape being deserialized when running the "
+ "query protocol. This pain will be carried forward when migrating to a new protocol "
Expand Down
4 changes: 2 additions & 2 deletions ...software/amazon/smithy/aws/traits/errorfiles/protocols/query-errors-must-be-unique.errors
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
[WARNING] smithy.example#QueryCompatibleService: Multiple error shapes with the error code `ResourceNotFound` found: [smithy.example#DocumentNotFound, smithy.example#ResourceNotFound]. This error code ambiguity will result in the wrong error shape being deserialized when running the query protocol. This pain will be carried forward when migrating to a new protocol when using the awsQueryCompatible trait. | QueryErrorCode
[WARNING] smithy.example#QueryService: Multiple error shapes with the error code `ResourceNotFound` found: [smithy.example#DocumentNotFound, smithy.example#ResourceNotFound]. This error code ambiguity will result in the wrong error shape being deserialized when running the query protocol. This pain will be carried forward when migrating to a new protocol when using the awsQueryCompatible trait. | QueryErrorCode
[DANGER] smithy.example#QueryCompatibleService: Multiple error shapes with the error code `ResourceNotFound` found: [smithy.example#DocumentNotFound, smithy.example#ResourceNotFound]. This error code ambiguity will result in the wrong error shape being deserialized when running the query protocol. This pain will be carried forward when migrating to a new protocol when using the awsQueryCompatible trait. | QueryErrorCode
[DANGER] smithy.example#QueryService: Multiple error shapes with the error code `ResourceNotFound` found: [smithy.example#DocumentNotFound, smithy.example#ResourceNotFound]. This error code ambiguity will result in the wrong error shape being deserialized when running the query protocol. This pain will be carried forward when migrating to a new protocol when using the awsQueryCompatible trait. | QueryErrorCode
Loading