Add AWS_PARTITIONS_FILE_OVERRIDE env variable#2794
Merged
Conversation
sugmanue
approved these changes
Oct 13, 2025
This allows for easily overriding the partitions.json file used to resolve partition metadata for the endpoints rules engine.
mtdowling
force-pushed
the
partition-override-envvar
branch
from
622c026 to
fee246e
Compare
sugmanue
approved these changes
Oct 13, 2025
yasmewad
reviewed
Oct 15, 2025
| .getPartitions()); | ||
| initializeRegionMap(); | ||
| // Use the override if present in the environment. Ignore an empty string value. | ||
| String override = System.getenv(AWS_PARTITIONS_FILE_OVERRIDE); |
Contributor
There was a problem hiding this comment.
I know this was merged but do we need to update any existing tests or add new test cases?
Member
Author
There was a problem hiding this comment.
Since it needs to reload the class and use a custom environment variable to test this behavior, I didn't see a reasonable way to test this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for easily overriding the partitions.json file used to resolve partition metadata for the endpoints rules engine.
Background
Testing
Links
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.