Fix smoke test missing params#2795
Merged
milesziemer merged 2 commits intosmithy-lang:mainfrom Oct 15, 2025
Merged
Conversation
If a smoke test case didn't define input `params`, the validation that normally checks to make sure `params` matches the operation input would not run. This meant that you could omit `params` even if the operation input has required members. I fixed this by manually checking for required members when `params` aren't defined (I couldn't use NodeValidationVisitor because it needs an actual node to check, plus the error message will be better this way). It emits an error, same as NodeValidationVisitor would.
Removed a branch in the smoke test input param validation logic, which would check for cases where `params` were provided for an operation with no input. This code was unreachable because the method being used to get the operation's input shape, `OperationIndex::expectInputShape`, always returns a value, and we were checking for null. There wasn't a test case for this, so I'm not sure why I wrote it that way to begin with.
yefrig
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a smoke test case didn't define input
params, the validation that normally checks to make sureparamsmatches the operation input would not run. This meant that you could omitparamseven if the operation input has required members.I fixed this by manually checking for required members when
paramsaren't defined (I couldn't use NodeValidationVisitor because it needs an actual node to check, plus the error message will be better this way). It emits an error, same as NodeValidationVisitor would.Commit 2:
Removed a branch in the smoke test input param validation logic, which would check for cases where
paramswere provided for an operation with no input. This code was unreachable because the method being used to get the operation's input shape,OperationIndex::expectInputShape, always returns a value, and we were checking for null. There wasn't a test case for this, so I'm not sure why I wrote it that way to begin with.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.