Fix changlog reading and new-change generation#2807
Merged
JordonPhillips merged 3 commits intomainfrom Oct 23, 2025
Merged
Conversation
This fixes the base location when attempting to read staged changelog entries to use the pr location rather than the base, where it won't exist.
This updates new-change to not add in an empty pr if the template section for prs is empty
JordonPhillips
commented
Oct 23, 2025
| uv run amend \ | ||
| --review-comment \ | ||
| --pull-request-number "$REPO_NUMBER" \ | ||
| --pull-request-number "$PR_NUMBER" \ |
Contributor
Author
There was a problem hiding this comment.
Note that this environment variable is set in the env block above, and its value will be printed in the logs. If you check the logs for this run, for example, you can see it has the value 2807.
sugmanue
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes some bugs in the changelog tool.
[""]instead of[].By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.