Skip to content

Add NodeValidationVisitor feature that enforces base64 encoding of blob values#2838

Merged
JordonPhillips merged 3 commits intosmithy-lang:mainfrom
brandondahler:features/RequireBase64BlobValues
Nov 12, 2025
Merged

Add NodeValidationVisitor feature that enforces base64 encoding of blob values#2838
JordonPhillips merged 3 commits intosmithy-lang:mainfrom
brandondahler:features/RequireBase64BlobValues

Conversation

@brandondahler
Copy link
Contributor

Background

Testing

  • How did you test these changes?
    • Left all existing tests alone
    • Added new parameterized test to verify both positive and negative cases for the blob behavior when the feature is enabled

Links


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@brandondahler brandondahler requested a review from a team as a code owner November 12, 2025 00:06
…4e34a46b.json

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

@JordonPhillips JordonPhillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Once this is in I'll need to add it to the new event stream protocol test trait

…4e34a46b.json

Co-authored-by: Jordon Phillips <JordonPhillips@users.noreply.github.com>
@JordonPhillips JordonPhillips merged commit fb91fea into smithy-lang:main Nov 12, 2025
10 checks passed
@brandondahler brandondahler deleted the features/RequireBase64BlobValues branch November 12, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants