Add NodeValidationVisitor feature that enforces base64 encoding of blob values#2838
Merged
JordonPhillips merged 3 commits intosmithy-lang:mainfrom Nov 12, 2025
Conversation
.changes/next-release/feature-22e1dd049a18d2fdf13cf205af81f5374e34a46b.json
Show resolved
Hide resolved
…4e34a46b.json Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
JordonPhillips
requested changes
Nov 12, 2025
Contributor
JordonPhillips
left a comment
There was a problem hiding this comment.
Great work! Once this is in I'll need to add it to the new event stream protocol test trait
.changes/next-release/feature-22e1dd049a18d2fdf13cf205af81f5374e34a46b.json
Outdated
Show resolved
Hide resolved
…4e34a46b.json Co-authored-by: Jordon Phillips <JordonPhillips@users.noreply.github.com>
JordonPhillips
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
REQUIRE_BASE_64_BLOB_VALUESNodeValidationVisitor Feature which enforces that blob values are valid base64-encoded valuesstringvalue that is base64 encoded."; however, existing trait validators and related code generators do not necessarily follow this specification.Testing
Links
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.