Skip to content

Refactor Dockerfile and IoUtils for improved robustness#2932

Closed
RinZ27 wants to merge 1 commit intosmithy-lang:mainfrom
RinZ27:fix/security-hardening-docker-and-iouutils
Closed

Refactor Dockerfile and IoUtils for improved robustness#2932
RinZ27 wants to merge 1 commit intosmithy-lang:mainfrom
RinZ27:fix/security-hardening-docker-and-iouutils

Conversation

@RinZ27
Copy link

@RinZ27 RinZ27 commented Jan 15, 2026

Improved the operational security of the Smithy container image by adding a dedicated non-root user and health checks. \n\nAdditionally, updated to support command execution via argument arrays. This provides a more robust and idiomatic way to handle subprocesses, reducing the likelihood of issues related to shell meta-character handling when executing external commands.

@RinZ27 RinZ27 requested a review from a team as a code owner January 15, 2026 14:50
@RinZ27 RinZ27 requested a review from yasmewad January 15, 2026 14:50
@github-actions
Copy link
Contributor

This pull request does not contain a staged changelog entry. To create one, use the ./.changes/new-change command. For example:

./.changes/new-change --pull-requests "#2932" --type feature --description "Refactor Dockerfile and IoUtils for improved robustness"

Make sure that the description is appropriate for a changelog entry and that the proper feature type is used. See ./.changes/README or run ./.changes/new-change -h for more information.

Added a non-root user and HEALTHCHECK to the Dockerfile to follow operational best practices. Also introduced an overload for IoUtils.runCommand that accepts argument arrays, facilitating safer command execution by avoiding shell interpolation risks.
@RinZ27 RinZ27 force-pushed the fix/security-hardening-docker-and-iouutils branch from 1bf2ebc to b2d4809 Compare January 15, 2026 15:02
@sugmanue
Copy link
Contributor

Hi @RinZ27, we don't review PR from unknown sources without a clear understanding of what's the issue being addressed. Please fill up an issue describing your concerns and preferably examples to show how would it be possible to exploit any if problem mentioned.

@sugmanue sugmanue closed this Jan 15, 2026
@RinZ27
Copy link
Author

RinZ27 commented Jan 16, 2026

Understood. I'll open an issue detailing the shell injection risks in IoUtils and the container security improvements, including the requested examples. Will link it here shortly.

@RinZ27
Copy link
Author

RinZ27 commented Jan 16, 2026

I've opened issue #2933 with the detailed explanation and Proof of Concept (PoC) for the shell injection vulnerability, as well as the rationale for the container hardening changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants