Fix SSA transform for transitive dependencies#2946
Merged
Conversation
Contributor
|
This pull request does not contain a staged changelog entry. To create one, use the Make sure that the description is appropriate for a changelog entry and that the proper feature type is used. See |
When variable A references variable B, and B gets SSA-renamed, A also needs unique names even if A's expression text is identical across branches. Example: 1. parts = split(input, delim, 0); part1 = getAttr(parts, "[0]") 2. parts = split(input, delim, 1); part1 = getAttr(parts, "[0]") "parts" gets renamed to parts_ssa_1/parts_ssa_2, but "part1" wasn't being renamed despite referencing "parts". After rewriting, the expressions diverge, causing BDD validation failures.
mtdowling
force-pushed
the
fix-ssa-nesting
branch
from
05c4978 to
3b07854
Compare
kstich
approved these changes
Jan 27, 2026
landonxjames
added a commit
to landonxjames/smithy
that referenced
this pull request
Jan 27, 2026
Note the split model currently won't compile due to the bug fixed in smithy-lang#2946 Commiting so I can pull that change in and regenerate
landonxjames
added a commit
to landonxjames/smithy
that referenced
this pull request
Jan 27, 2026
sugmanue
added a commit
that referenced
this pull request
Jan 29, 2026
…ased tests (#2945) * Add tree versions of coalesce, ite, and split tests * Add bdd based rule set std lib function tests Also split tests into separate bdd-tests and tree-tests folders * Add cahngelog entry * Centralize both tree rules and BDD rules in single test models Note the split model currently won't compile due to the bug fixed in #2946 Commiting so I can pull that change in and regenerate * Recompiled split test BDD with changes from #2946 * Remove endpointBDD traits from smithy-rules-engine-tests Automating adding them back is tracked in #2949 * Remove use statements for endpointBdd trait * Format tests --------- Co-authored-by: Manuel Sugawara (∩｀-´)⊃━炎炎炎炎炎 <sugmanue@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When variable A references variable B, and B gets SSA-renamed, A also needs unique names even if A's expression text is identical across branches.
Example:
"parts" gets renamed to parts_ssa_1/parts_ssa_2, but "part1" wasn't being renamed despite referencing "parts". After rewriting, the expressions diverge, causing BDD validation failures.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.