Tweak wording of integers with ranges message#2971
Merged
Conversation
Contributor
|
This pull request does not contain a staged changelog entry. To create one, use the Make sure that the description is appropriate for a changelog entry and that the proper feature type is used. See |
d3100f4 to
755147c
Compare
yasmewad
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The purpose of this validation is to push
@rangetraits on to distinctintegers in a model, so clarify the message to apply to targets.Why not make this target members?
Having this apply to members means that each place the same potential values need to be specified, they must be kept in sync. This is prone to mistakes if the same value in the range needs to be adjusted in multiple locations.
Why not exclude the prelude
smithy.api#Integer?This doesn't solve the problem that the validation expects. Exempting members that target the prelude integer doesn't force all integer input to be bound.
Links
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.