Skip to content

Tweak wording of integers with ranges message#2971

Merged
yasmewad merged 1 commit intomainfrom
dev/kstich/validation-docs-fix-1
Feb 20, 2026
Merged

Tweak wording of integers with ranges message#2971
yasmewad merged 1 commit intomainfrom
dev/kstich/validation-docs-fix-1

Conversation

@kstich
Copy link
Contributor

@kstich kstich commented Feb 20, 2026

Background

The purpose of this validation is to push @range traits on to distinct integers in a model, so clarify the message to apply to targets.

Why not make this target members?

Having this apply to members means that each place the same potential values need to be specified, they must be kept in sync. This is prone to mistakes if the same value in the range needs to be adjusted in multiple locations.

Why not exclude the prelude smithy.api#Integer?

This doesn't solve the problem that the validation expects. Exempting members that target the prelude integer doesn't force all integer input to be bound.

Links


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kstich kstich requested a review from a team as a code owner February 20, 2026 17:56
@kstich kstich requested a review from yasmewad February 20, 2026 17:56
@github-actions
Copy link
Contributor

This pull request does not contain a staged changelog entry. To create one, use the ./.changes/new-change command. For example:

./.changes/new-change --pull-requests "#2971" --type feature --description "Tweak wording of integers with ranges message"

Make sure that the description is appropriate for a changelog entry and that the proper feature type is used. See ./.changes/README or run ./.changes/new-change -h for more information.

@kstich kstich force-pushed the dev/kstich/validation-docs-fix-1 branch from d3100f4 to 755147c Compare February 20, 2026 18:00
@yasmewad yasmewad merged commit 730d408 into main Feb 20, 2026
16 checks passed
@yasmewad yasmewad deleted the dev/kstich/validation-docs-fix-1 branch February 20, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants