Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "other",
"description": "Removed protocol tests for skipping null values in dense collections. This behavior can silently drop data. SDKs that cannot preserve null values should raise an exception instead",
"pull_requests": [
"[#2972](https://github.com/smithy-lang/smithy/pull/2972)"
]
}
27 changes: 0 additions & 27 deletions smithy-aws-protocol-tests/model/restJson1/json-maps.smithy
Original file line number Diff line number Diff line change
Expand Up @@ -187,33 +187,6 @@ apply JsonMaps @httpResponseTests([
"y": ["a", "b"]
}
}
},
{
id: "RestJsonDeserializesDenseSetMapAndSkipsNull",
documentation: """
Clients SHOULD tolerate seeing a null value in a dense map, and they SHOULD
drop the null key-value pair.""",
protocol: restJson1,
appliesTo: "client",
code: 200,
body: """
{
"denseSetMap": {
"x": [],
"y": ["a", "b"],
"z": null
}
}""",
bodyMediaType: "application/json",
headers: {
"Content-Type": "application/json"
},
params: {
"denseSetMap": {
"x": [],
"y": ["a", "b"]
}
}
}
])

Expand Down
21 changes: 0 additions & 21 deletions smithy-protocol-tests/model/rpcv2Cbor/cbor-maps.smithy
Original file line number Diff line number Diff line change
Expand Up @@ -156,27 +156,6 @@ apply RpcV2CborDenseMaps @httpResponseTests([
"y": ["a", "b"]
}
}
},
{
id: "RpcV2CborDeserializesDenseSetMapAndSkipsNull",
documentation: """
Clients SHOULD tolerate seeing a null value in a dense map, and they SHOULD
drop the null key-value pair.""",
protocol: rpcv2Cbor,
appliesTo: "client",
code: 200,
body: "oWtkZW5zZVNldE1hcKNheIBheYJhYWFiYXr2",
bodyMediaType: "application/cbor",
headers: {
"smithy-protocol": "rpc-v2-cbor",
"Content-Type": "application/cbor"
},
params: {
"denseSetMap": {
"x": [],
"y": ["a", "b"]
}
}
}
])

Expand Down
Loading