feat: filter out addresses not supported by strategies and validation

[wa0x6e]

Toward https://github.com/snapshot-labs/workflow/issues/562

This PR adds a new property to the strategy and validation object, to define the list of protocols supported (evm and/or starknet).

It will default to ['evm'] by default, for backward compatibility with existing strategies.

Address not supported will be filtered out before processing the strategy/validation

Note

• Waiting for feat: accept starknet address when fetching vp or validation snapshot.js#1149
• Waiting for feat: allow starknet address in schema and when signing snapshot.js#1152

[Copilot]

Pull Request Overview

Introduce protocol-aware address filtering and validation to ensure strategies and validators only process supported address types.

• Add supportedProtocols and a validateAddressType method to the Validation class and invoke it in existing validators.
• Implement getFormattedAddressesByProtocol in core utils and apply it to normalize addresses according to each strategy’s supported protocols.
• Define DEFAULT_SUPPORTED_PROTOCOLS (['evm']) and propagate default protocol support in validations and strategies indexes.

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/validations/validation.ts	Add supportedProtocols property and validateAddressType
src/validations/index.ts	Fallback to DEFAULT_SUPPORTED_PROTOCOLS for validators
src/utils.ts	Introduce getFormattedAddressesByProtocol helper
src/utils/vp.ts	Apply protocol-based formatting in VP calculations
src/strategies/index.ts	Fallback to DEFAULT_SUPPORTED_PROTOCOLS for strategies
src/index.ts	Define DEFAULT_SUPPORTED_PROTOCOLS

Comments suppressed due to low confidence (2)

src/validations/index.ts:64

• Using || will treat an empty array as truthy, causing validators without explicit protocols to end up with an empty list. Consider checking length or using nullish coalescing (??) so that fallback applies when supportedProtocols is empty or undefined.

supportedProtocols: validationInstance.supportedProtocols || DEFAULT_SUPPORTED_PROTOCOLS

src/validations/validation.ts:36

• The new validateAddressType method introduces protocol-specific validation logic but has no unit tests. Adding targeted tests will help prevent regressions when address‐formatting rules change.

validateAddressType(): boolean {

[Copilot]

Pull Request Overview

This PR introduces protocol filtering for strategies and validations by adding a new property to specify supported protocols, ensuring that addresses unsupported by the chosen protocols are filtered out before processing. Key changes include updating validations and strategies to use the new supportedProtocols property, refactoring snapshot types to use the unified Snapshot type, and adding utility functions for protocol-based address formatting.

Reviewed Changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
test/strategy-with-params.test.ts	Cast snapshot to Snapshot type for more explicit typing.
src/validations/*	Update validation classes with supportedProtocols and refactor validate methods.
src/utils/*	Replace direct getAddress calls with protocol-based address formatting.
src/types.ts	Add new type definitions including Protocol and Snapshot.
src/strategies/*	Add supportedProtocols property and update snapshot type usage.
package.json	Update test scripts to run unit tests.

Comments suppressed due to low confidence (1)

src/utils/vp.ts:85

• The use of 'i' in strategies[i].supportedProtocols is unclear because no index variable 'i' is defined in this context. Consider using the already provided iteration variable (e.g. 'strategy') to reference the supportedProtocols property.

addresses = getFormattedAddressesByProtocol(addresses, strategies[i].supportedProtocols)

[ChaituVR]

@wa0x6e any idea why build fail?

[wa0x6e]

@wa0x6e any idea why build fail?

it's depending on a snapshot.js pr

[wa0x6e]

Tests are now passing thanks to the dependency update

[ChaituVR]

Everything else looks good

[wa0x6e]

I've also added unit test run on CI.

Seems to fail on a sha256 import, I have the same issue on local. Not sure what's wrong with export from utils ...

[ChaituVR]

looking good, just the test case is failing

[ChaituVR]

Tests pass now

[ChaituVR]

utAck