This repository was archived by the owner on Aug 22, 2025. It is now read-only.
test: add integration test for basic validation#1761
Merged
Conversation
wa0x6e
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds scaffolding for integration tests and marks missing validation for network inputs.
- Introduces a
test:integrationnpm script to run integration tests - Inserts a TODO in the validation logic to handle invalid networks
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/validations/validation.ts | Added a TODO placeholder for invalid network handling |
| package.json | Added test:integration script for integration tests |
Comments suppressed due to low confidence (1)
src/validations/validation.ts:34
- Implement the invalid network validation logic or remove this TODO to avoid leaving unimplemented code paths in production.
// TODO: validate invalid networks
| "test:vp": "jest -i vp.test.ts", | ||
| "test:delegation": "jest -i delegation.test.ts", | ||
| "test:validation": "jest -i validation.test.ts", | ||
| "test:integration": "jest -i test/integration/", |
There was a problem hiding this comment.
[nitpick] Refine the Jest test script to target only integration test files, for example: "jest -i "test/integration/**/*.test.ts"" to avoid running unrelated files.
Suggested change
| "test:integration": "jest -i test/integration/", | |
| "test:integration": "jest -i \"test/integration/**/*.test.ts\"", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add integration test for basic validation, adding 22 new tests