Skip to content
This repository was archived by the owner on Aug 22, 2025. It is now read-only.

Comments

[overtime] Overtime strategy#1762

Merged
ChaituVR merged 8 commits intosnapshot-labs:masterfrom
thales-markets:master
Jun 26, 2025
Merged

[overtime] Overtime strategy#1762
ChaituVR merged 8 commits intosnapshot-labs:masterfrom
thales-markets:master

Conversation

@vladanthales
Copy link
Contributor

Changes proposed in this pull request:

  • Create a new strategy for Overtime governance (ex Thales).


export const author = 'thales-markets';
export const version = '1.0.0';
export const dependOnOtherAddress = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vladanthales We are not accepting new strategies that override due to scaling issue, Instead you can use api-v2-override strategy in your space to call the API instead, let me know if you have any questions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked api-v2-override, but I don't see how I can use that here (that strategy uses API to get scores for addresses). In my strategy, my API returns EOA/smartAccount map (since the voter can't vote with a smart account, I want to assign that score to EOA). So, score is still based on balance-of strategy, just I need map from API.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have an old thales strategy, can I update that strategy with this code and use that one (since it's old strategy)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm thales strategy is not a override strategy 🙈 overriding is important for you? or you added export const dependOnOtherAddress = true; by mistake?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I double-checked and removed that part. No need to override smartAccount voting power, since user can't vote with smartAccount. Code updated.

@ChaituVR ChaituVR merged commit 3cb1625 into snapshot-labs:master Jun 26, 2025
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants