fix: add validations to getVp and getScoresDirect

[wa0x6e]

Continuing on #1771

This PR:

• adds back the address validation to getVp
• send only relevant addresses to strategies, depending on supported protocols
• throws an error on empty strategies in getVp (it allows empty on getScoresDirect

[Copilot]

Pull Request Overview

This PR restores address validations in getVp, refines getScoresDirect to only send relevant addresses to each strategy based on supported protocols, and enforces an error when getVp is called with an empty strategy list.

• Replaced the old getFormattedAddressesByProtocol and protocol‐validation logic with detectProtocol, categorizeAddressesByProtocol, and filterAddressesForStrategy.
• Introduced validateStrategies in both getScoresDirect and getVp, and throw an error on empty strategy arrays.
• Updated integration tests, fixtures, and snapshots to cover new validation behaviors and error messages.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
test/unit/utils.test.ts	Remove outdated tests for getFormattedAddressesByProtocol.
test/integration/validation/basic.test.ts	Adjust expected error message from singular to plural “Invalid strategies”.
test/integration/utils.test.ts	Expand integration tests for getVp covering invalid addresses and strategy errors.
test/integration/fixtures/vp-fixtures.ts	Add fixture definitions for network, addresses, and strategy sets.
test/integration/snapshots/utils.test.ts.snap	Update snapshot keys and contents to match new test descriptions.
src/utils.ts	Remove old protocol‐formatting export; add new protocol detection, categorization, strategy filtering, and validations.

Comments suppressed due to low confidence (2)

src/utils.ts:58

• Consider adding a direct unit or integration test for getScoresDirect when addresses is empty to verify it returns an array of empty score objects as intended.

    if (addresses.length === 0) return strategies.map(() => ({}));

src/utils.ts:148

• [nitpick] It would improve maintainability to add a JSDoc comment above categorizeAddressesByProtocol describing its parameters, return shape, and error cases (e.g. invalid address format).

function categorizeAddressesByProtocol(

[ChaituVR]

tAck