Open
Conversation
Collaborator
|
We refactored |
basilgello
suggested changes
Jun 24, 2021
basilgello
left a comment
basilgello
left a comment
There was a problem hiding this comment.
Also need to replace sudo invocations with $SUDO
install.sh
Outdated
| GDB_PYTHON="${GDB_PYTHON/%$GDB_PYVER/}${GDB_PYVER}" | ||
|
|
||
| install_packages | ||
| install_packages $PYVER |
There was a problem hiding this comment.
This will throw a missing python-dev package on Debian bullseye and newer.
Keeping only next line L#143 is enough
install.sh
Outdated
| fi | ||
|
|
||
| install_packages | ||
| install_packages $PYVER |
layderv
force-pushed
the
master
branch
2 times, most recently
from
7af2acd to
15046c8
Compare
basilgello
reviewed
Jun 25, 2021
| _PYVER=$1 | ||
| if echo $_PYVER|grep "3\."; then | ||
| sudo apt-get -y install libreadline6-dev python3-dev python3-setuptools python3-yaml python3-pip | ||
| else |
There was a problem hiding this comment.
sudo -> ${SUDO}
Since in containers there is no sudo typically installed.
basilgello
reviewed
Jun 25, 2021
| _PYVER=$1 | ||
| if echo $_PYVER|grep "3\."; then | ||
| sudo $CMD $PARAMS install readline-devel python3-devel python3-setuptools python3-yaml python3-pip | ||
| else |
basilgello
suggested changes
Jun 25, 2021
basilgello
left a comment
basilgello
left a comment
There was a problem hiding this comment.
Please replace unconditional sudo invocations with ${SUDO}, too. For example, running Voltron in a rootless container is totally fine but there is no sudo nor anybother setuid executable installed.
Author
|
Fixed |
|
@zcutlip ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #245