Additionalpropertiesfalse generates invalid java code with mapstring#369
Open
jemacineiras wants to merge 4 commits intomainfrom
Open
Additionalpropertiesfalse generates invalid java code with mapstring#369jemacineiras wants to merge 4 commits intomainfrom
jemacineiras wants to merge 4 commits intomainfrom
Conversation
…p field When additionalProperties is explicitly set to false, the generator should not create a Map field. Previously, any presence of additionalProperties would generate a Map regardless of its boolean value. Changes: - ModelBuilder.java: Updated processAdditionalProperties() to check if boolean false and skip Map generation - ModelBuilder.java: Updated setFieldType() to handle boolean false case - ModelBuilder.java: Updated getMapTypeObject() to safely handle boolean nodes - Added testAdditionalPropertiesFalse test case with YAML, expected DTO, and API - Bump patch version to 6.3.2 (bug fix) Fixes issue #367: additionalProperties false generates invalid Java code"
…lse-generates-invalid-java-code-with-mapstring
apenlor
previously approved these changes
Dec 15, 2025
apenlor
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#368 Additional properties false generates invalid java code with map, string