forked from Expensify/App
-
Notifications
You must be signed in to change notification settings - Fork 0
Fix findMessageInSource to handle messages with http statuses at the beginning #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chuckdries
wants to merge
300
commits into
software-mansion-labs:korytko/ecuk/3ds/implement-native-hooks
Choose a base branch
from
Expensify:chuckdries/ecuk/3ds/fix-invalid-validatecode-error-handling
base: korytko/ecuk/3ds/implement-native-hooks
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…istingReport function
…7-splitsLogicUpdate
…-transaction-threads
…D-for-transaction-threads Handle the preExistingReportID for transaction threads, message threads, and single expense reports
…mission fix: preserve navigation state when opening settings from Onfido permission flow
fix: distance rates not enabled while duplicating a workspace offline
fix: device back button doesn't close FAB menu
fix: remove missing description violation once turn off rule
Replace expo-av with expo-audio
…olation-not-showing-after-category-change
Remove unnecessary fix
Reapply "Fix filtering attendees names in the `Reports` page" and add improvements
…ed-visible-report-actions-derived Revert "Reverted new Onyx Derived Value VISIBLE_REPORT_ACTIONS, blockers fix"
[CHAI] Replace Google search with SearchHelpsite
fix/80826: Reports - Multi level tags separated by comma
Notification preference: return `hidden` if empty
…mation-modal-PR-4 Refactored ConfirmModal usage to useConfirmModal
Remove policyID from TrackExpense CREATE flow
fix: manually entering details makes split option missing
…llowup fix: useSubPage followup
Fix: Some approvals pages are shown when workflows is disabled in another browser
…beginning of them
…ix-invalid-validatecode-error-handling
Author
|
I went ahead and solved the merge conflict with main as well :) |
bcfa7b4 to
d6fbc94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auth throws messages that follow the format
"${httpCode} ${message}", so when we're comparing the messages against a known list of expected messages, we need to ignore the http code at the beginning. In the future, it seems like we could maybe take advantage of this to simplify the API response map (which is currently keyed by http code), but we don't need to do that now.This change fixes invalid magic code handling