Draft
Conversation
wisniewskij
force-pushed
the
@wisniewskij/css-svg-path-parse-on-js-side
branch
from
7b2c96d to
8fbfda0
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 12, 2026
## Summary In the previous version of SVGPath cpp parser there was a bug that in an uncommon situation that somebody closes path with Z and after that writes commands without creating new subpath with M, the Z would be implicitly moved to the end changing the outcome. This is a temporary bugfix before #8820 gets merged.
Contributor
Author
|
Add test checking if the path is not empty (should filter out subpaths where there is M or Z but no C) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In my previous PR (#8710) I added code that partially parses SVG Path on the JS's side and then continues the process in native code. I decided to refactor that so entire parsing happens on JS's side.
Test plan
Modified unit tests so the entire output structure is now tested: