Don't cleanup layout animations on the JS thread#8852
Open
bartlomiejbloniarz wants to merge 1 commit intomainfrom
Open
Don't cleanup layout animations on the JS thread#8852bartlomiejbloniarz wants to merge 1 commit intomainfrom
bartlomiejbloniarz wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR skips layout animation cleanup when the
preserveMountedTags_function return false due to being called on the jsThread. Up to this point we simply skippedaddOngoingid the transaction was called on the js thread, but this could lead to cleanup happening before we apply the animation (for duration 0 animations, this would mean the view never moves). So now if it was called no the js thread we skip cleanup and let it happen when the main thread is invoked withpullTransaction. This issue can happen only on android and should be gone when the pull model/branching is implemented.BEFORE
Screen.Recording.2026-01-21.at.14.47.41.mov
AFTER
Screen.Recording.2026-01-21.at.14.46.19.mov
Test plan
[LA] Duration Zero layout with Virtualizationexample