Skip to content

Enable collect histograms by default #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
etichy wants to merge 1 commit into from
Closed

Enable collect histograms by default #1219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions deploy/helm/tests/__snapshot__/gateway-config-map_test.yaml.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,10 +414,6 @@ Gateway config should match snapshot when using default values:
send_batch_max_size: 1024
send_batch_size: 1024
timeout: 1s
filter/histograms:
metrics:
metric:
- type == METRIC_DATA_TYPE_HISTOGRAM
filter/obi-self-loop-relationships:
error_mode: ignore
metrics:
Expand Down Expand Up @@ -822,7 +818,6 @@ Gateway config should match snapshot when using default values:
- forward/metrics_common
processors:
- memory_limiter
- filter/histograms
receivers:
- routing/metrics
metrics/common_in:
Expand Down
8 changes: 0 additions & 8 deletions deploy/helm/tests/__snapshot__/metrics-collector-config-map-fargate_test.yaml.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,13 +225,6 @@ Metrics config should match snapshot when using default values:
- k8s.node.network.packets_transmitted
- k8s.node.network.receive_packets_dropped
- k8s.node.network.transmit_packets_dropped
filter/histograms:
metrics:
metric:
- type == METRIC_DATA_TYPE_HISTOGRAM and not( name == "k8s.apiserver_request_duration_seconds"
or name == "k8s.workqueue_queue_duration_seconds" or name == "k8s.coredns_dns_request_duration_seconds"
or name == "k8s.coredns_dns_request_size_bytes" or name == "k8s.coredns_dns_response_size_bytes"
or name == "k8s.istio_request_duration_milliseconds" )
filter/kube-state-metrics:
metrics:
metric:
Expand Down Expand Up @@ -1715,7 +1708,6 @@ Metrics config should match snapshot when using default values:
- otlp
processors:
- memory_limiter
- filter/histograms
- transform/scope
- batch
receivers:
Expand Down
24 changes: 0 additions & 24 deletions deploy/helm/tests/__snapshot__/metrics-collector-config-map_test.yaml.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,13 +225,6 @@ Metrics config should match snapshot when fargate is enabled:
- k8s.node.network.packets_transmitted
- k8s.node.network.receive_packets_dropped
- k8s.node.network.transmit_packets_dropped
filter/histograms:
metrics:
metric:
- type == METRIC_DATA_TYPE_HISTOGRAM and not( name == "k8s.apiserver_request_duration_seconds"
or name == "k8s.workqueue_queue_duration_seconds" or name == "k8s.coredns_dns_request_duration_seconds"
or name == "k8s.coredns_dns_request_size_bytes" or name == "k8s.coredns_dns_response_size_bytes"
or name == "k8s.istio_request_duration_milliseconds" )
filter/kube-state-metrics:
metrics:
metric:
Expand Down Expand Up @@ -1715,7 +1708,6 @@ Metrics config should match snapshot when fargate is enabled:
- otlp
processors:
- memory_limiter
- filter/histograms
- transform/scope
- batch
receivers:
Expand Down Expand Up @@ -2030,13 +2022,6 @@ Metrics config should match snapshot when using Prometheus url with extra_scrape
- k8s.node.network.packets_transmitted
- k8s.node.network.receive_packets_dropped
- k8s.node.network.transmit_packets_dropped
filter/histograms:
metrics:
metric:
- type == METRIC_DATA_TYPE_HISTOGRAM and not( name == "k8s.apiserver_request_duration_seconds"
or name == "k8s.workqueue_queue_duration_seconds" or name == "k8s.coredns_dns_request_duration_seconds"
or name == "k8s.coredns_dns_request_size_bytes" or name == "k8s.coredns_dns_response_size_bytes"
or name == "k8s.istio_request_duration_milliseconds" )
filter/kube-state-metrics:
metrics:
metric:
Expand Down Expand Up @@ -3455,7 +3440,6 @@ Metrics config should match snapshot when using Prometheus url with extra_scrape
- otlp
processors:
- memory_limiter
- filter/histograms
- transform/scope
- batch
receivers:
Expand Down Expand Up @@ -3777,13 +3761,6 @@ Metrics config should match snapshot when using default values:
- k8s.node.network.packets_transmitted
- k8s.node.network.receive_packets_dropped
- k8s.node.network.transmit_packets_dropped
filter/histograms:
metrics:
metric:
- type == METRIC_DATA_TYPE_HISTOGRAM and not( name == "k8s.apiserver_request_duration_seconds"
or name == "k8s.workqueue_queue_duration_seconds" or name == "k8s.coredns_dns_request_duration_seconds"
or name == "k8s.coredns_dns_request_size_bytes" or name == "k8s.coredns_dns_response_size_bytes"
or name == "k8s.istio_request_duration_milliseconds" )
filter/kube-state-metrics:
metrics:
metric:
Expand Down Expand Up @@ -5187,7 +5164,6 @@ Metrics config should match snapshot when using default values:
- otlp
processors:
- memory_limiter
- filter/histograms
- transform/scope
- batch
receivers:
Expand Down
6 changes: 0 additions & 6 deletions deploy/helm/tests/__snapshot__/metrics-discovery-config-map_test.yaml.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,11 +383,6 @@ Metrics discovery config should match snapshot when Fargate is enabled:
- k8s.istio_requests.rate
- k8s.istio_tcp_sent_bytes.rate
- k8s.istio_tcp_received_bytes.rate
filter/histograms:
metrics:
metric:
- type == METRIC_DATA_TYPE_HISTOGRAM and not(name == "k8s.rest_client_request_duration_seconds"
or name == "k8s.workqueue_queue_duration_seconds")
filter/keep-entity-state-events:
logs:
log_record:
Expand Down Expand Up @@ -774,7 +769,6 @@ Metrics discovery config should match snapshot when Fargate is enabled:
- otlp
processors:
- memory_limiter
- filter/histograms
- k8sattributes
- filter/remove_temporary_metrics
- transform/scope
Expand Down
14 changes: 0 additions & 14 deletions deploy/helm/tests/__snapshot__/node-collector-config-map-windows_test.yaml.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,12 +482,6 @@ Node collector config for windows nodes should match snapshot when using default
- k8s.istio_requests.rate
- k8s.istio_tcp_sent_bytes.rate
- k8s.istio_tcp_received_bytes.rate
filter/histograms:
metrics:
metric:
- type == METRIC_DATA_TYPE_HISTOGRAM and not(name == "k8s.rest_client_request_duration_seconds"
or name == "k8s.workqueue_queue_duration_seconds" or name == "k8s.etcd_disk_wal_fsync_duration_seconds"
or name == "k8s.etcd_disk_backend_commit_duration_seconds")
filter/keep-entity-state-events:
logs:
log_record:
Expand Down Expand Up @@ -1681,7 +1675,6 @@ Node collector config for windows nodes should match snapshot when using default
- otlp
processors:
- memory_limiter
- filter/histograms
- k8sattributes
- filter/remove_temporary_metrics
- transform/scope
Expand Down Expand Up @@ -2300,12 +2293,6 @@ Node collector config for windows nodes should match snapshot when using legacy
- k8s.istio_requests.rate
- k8s.istio_tcp_sent_bytes.rate
- k8s.istio_tcp_received_bytes.rate
filter/histograms:
metrics:
metric:
- type == METRIC_DATA_TYPE_HISTOGRAM and not(name == "k8s.rest_client_request_duration_seconds"
or name == "k8s.workqueue_queue_duration_seconds" or name == "k8s.etcd_disk_wal_fsync_duration_seconds"
or name == "k8s.etcd_disk_backend_commit_duration_seconds")
filter/keep-entity-state-events:
logs:
log_record:
Expand Down Expand Up @@ -3588,7 +3575,6 @@ Node collector config for windows nodes should match snapshot when using legacy
- otlp
processors:
- memory_limiter
- filter/histograms
- k8sattributes
- filter/remove_temporary_metrics
- transform/scope
Expand Down
41 changes: 0 additions & 41 deletions deploy/helm/tests/__snapshot__/node-collector-config-map_test.yaml.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,12 +482,6 @@ Custom logs filter with new syntax:
- k8s.istio_requests.rate
- k8s.istio_tcp_sent_bytes.rate
- k8s.istio_tcp_received_bytes.rate
filter/histograms:
metrics:
metric:
- type == METRIC_DATA_TYPE_HISTOGRAM and not(name == "k8s.rest_client_request_duration_seconds"
or name == "k8s.workqueue_queue_duration_seconds" or name == "k8s.etcd_disk_wal_fsync_duration_seconds"
or name == "k8s.etcd_disk_backend_commit_duration_seconds")
filter/keep-entity-state-events:
logs:
log_record:
Expand Down Expand Up @@ -1722,7 +1716,6 @@ Custom logs filter with new syntax:
- otlp
processors:
- memory_limiter
- filter/histograms
- k8sattributes
- filter/remove_temporary_metrics
- transform/scope
Expand Down Expand Up @@ -2341,12 +2334,6 @@ Custom logs filter with old syntax:
- k8s.istio_requests.rate
- k8s.istio_tcp_sent_bytes.rate
- k8s.istio_tcp_received_bytes.rate
filter/histograms:
metrics:
metric:
- type == METRIC_DATA_TYPE_HISTOGRAM and not(name == "k8s.rest_client_request_duration_seconds"
or name == "k8s.workqueue_queue_duration_seconds" or name == "k8s.etcd_disk_wal_fsync_duration_seconds"
or name == "k8s.etcd_disk_backend_commit_duration_seconds")
filter/keep-entity-state-events:
logs:
log_record:
Expand Down Expand Up @@ -3665,7 +3652,6 @@ Custom logs filter with old syntax:
- otlp
processors:
- memory_limiter
- filter/histograms
- k8sattributes
- filter/remove_temporary_metrics
- transform/scope
Expand Down Expand Up @@ -4284,12 +4270,6 @@ Node collector config should match snapshot when autodiscovery is disabled:
- k8s.istio_requests.rate
- k8s.istio_tcp_sent_bytes.rate
- k8s.istio_tcp_received_bytes.rate
filter/histograms:
metrics:
metric:
- type == METRIC_DATA_TYPE_HISTOGRAM and not(name == "k8s.rest_client_request_duration_seconds"
or name == "k8s.workqueue_queue_duration_seconds" or name == "k8s.etcd_disk_wal_fsync_duration_seconds"
or name == "k8s.etcd_disk_backend_commit_duration_seconds")
filter/keep-entity-state-events:
logs:
log_record:
Expand Down Expand Up @@ -5459,7 +5439,6 @@ Node collector config should match snapshot when autodiscovery is disabled:
- otlp
processors:
- memory_limiter
- filter/histograms
- k8sattributes
- filter/remove_temporary_metrics
- transform/scope
Expand Down Expand Up @@ -6075,12 +6054,6 @@ Node collector config should match snapshot when fargate is enabled:
- k8s.istio_requests.rate
- k8s.istio_tcp_sent_bytes.rate
- k8s.istio_tcp_received_bytes.rate
filter/histograms:
metrics:
metric:
- type == METRIC_DATA_TYPE_HISTOGRAM and not(name == "k8s.rest_client_request_duration_seconds"
or name == "k8s.workqueue_queue_duration_seconds" or name == "k8s.etcd_disk_wal_fsync_duration_seconds"
or name == "k8s.etcd_disk_backend_commit_duration_seconds")
filter/keep-entity-state-events:
logs:
log_record:
Expand Down Expand Up @@ -7255,7 +7228,6 @@ Node collector config should match snapshot when fargate is enabled:
- otlp
processors:
- memory_limiter
- filter/histograms
- k8sattributes
- filter/remove_temporary_metrics
- transform/scope
Expand Down Expand Up @@ -7842,12 +7814,6 @@ Node collector config should match snapshot when fargate is enabled and autodisc
- k8s.istio_requests.rate
- k8s.istio_tcp_sent_bytes.rate
- k8s.istio_tcp_received_bytes.rate
filter/histograms:
metrics:
metric:
- type == METRIC_DATA_TYPE_HISTOGRAM and not(name == "k8s.rest_client_request_duration_seconds"
or name == "k8s.workqueue_queue_duration_seconds" or name == "k8s.etcd_disk_wal_fsync_duration_seconds"
or name == "k8s.etcd_disk_backend_commit_duration_seconds")
filter/keep-entity-state-events:
logs:
log_record:
Expand Down Expand Up @@ -9545,12 +9511,6 @@ Node collector config should match snapshot when using default values:
- k8s.istio_requests.rate
- k8s.istio_tcp_sent_bytes.rate
- k8s.istio_tcp_received_bytes.rate
filter/histograms:
metrics:
metric:
- type == METRIC_DATA_TYPE_HISTOGRAM and not(name == "k8s.rest_client_request_duration_seconds"
or name == "k8s.workqueue_queue_duration_seconds" or name == "k8s.etcd_disk_wal_fsync_duration_seconds"
or name == "k8s.etcd_disk_backend_commit_duration_seconds")
filter/keep-entity-state-events:
logs:
log_record:
Expand Down Expand Up @@ -10780,7 +10740,6 @@ Node collector config should match snapshot when using default values:
- otlp
processors:
- memory_limiter
- filter/histograms
- k8sattributes
- filter/remove_temporary_metrics
- transform/scope
Expand Down
2 changes: 1 addition & 1 deletion deploy/helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ otel:

# Filter out histogram metrics before sending to SWO
# Enabled by default due to SWO current limitations.
Copy link
Contributor

@pstranak-sw pstranak-sw Dec 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the comment, too, including in the schema.

filter_histograms: true
filter_histograms: false

# configuration for metric discovery
autodiscovery:
Expand Down
Loading