Apply namespace filter for OBI#1221
Merged
jakub-racek-swi merged 6 commits intomasterfrom Dec 10, 2025
Merged
Conversation
murad-sw
reviewed
Dec 8, 2025
| {{- range .Values.cluster.filter.exclude_namespaces }} | ||
| - k8s_namespace: {{ quote . }} | ||
| {{- end }} | ||
| {{- end }} |
Contributor
There was a problem hiding this comment.
if we both include and exclude some namespaces, then we will see this:
- k8s_namespace: "*"
- k8s_namespace: XYZ
or maybe I'm missing something?
Contributor
Author
There was a problem hiding this comment.
@murad-sw Having configured both include and exclude is undefined behavior, and we do not even allow it in wizard, so I'd say handling this case is unnecessary.
pstranak-sw
reviewed
Dec 8, 2025
| {{- if (not (empty .Values.cluster.filter.include_namespaces))}} | ||
| - k8s_namespace: "*" | ||
| {{- end }} | ||
| {{- if or (not (empty .Values.cluster.filter.exclude_namespaces)) (not (empty .Values.cluster.filter.exclude_namespaces_regex)) }} |
Contributor
There was a problem hiding this comment.
I don't see exclude_namespaces_regex used, only checked in this condition.
Contributor
Author
There was a problem hiding this comment.
I removed that check, it should behave as expected now.
murad-sw
approved these changes
Dec 10, 2025
pstranak-sw
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configmap update. There's no regex filter in the OBI configmap so I've added a pipeline filter as well.
include: include configured, exclude everything
exclude: exclude configured, include everything
else: include everything