Mark Pods deployed by k8s collector with "sw.k8s.deployedbycollector"#1242
Mark Pods deployed by k8s collector with "sw.k8s.deployedbycollector"#1242
Conversation
There was a problem hiding this comment.
We need to test whether this actually works, because the all container metrics (kube_pod_container_*) collected by this collector are marked with sw.entity.noupdate. I think it doesn't actually do anything. But if it does, it would make this change non-functional. But it would also mean that collecting container statuses, images, "init" info, etc. from metrics would not work either.
There was a problem hiding this comment.
I don't understand why do we instrument telemetry by anything at all here? We updated all pods that we deploy and all pods that are deployed by subcharts, so why do we need to update k8sattributes config at all?
There was a problem hiding this comment.
We need to extract a resource attribute out of the label. There are multiple ways how to achieve that. I used this one as it makes it unified with what I did in the manifest collection pipeline. And it allowed to me to add also the sanity check for to sure the resource attribute is not set in case of incorrect namespace.
There was a problem hiding this comment.
ok, clarified async. We will keep this backup there until we make sure that event collector and ingenstion of entity state events from manifest cannot be disabled.
There was a problem hiding this comment.
Changes in this file depend on solarwinds/solarwinds-otel-collector-contrib#220
| processors: | ||
| k8sattributes: | ||
| {{ include "common.k8s-instrumentation" . | indent 4 }} | ||
| auth_type: "serviceAccount" |
There was a problem hiding this comment.
I don't like this copy paste, but probably there's no other way.
There was a problem hiding this comment.
I'd actually prefer to remove most of the deduplicated code, as it only complicates investigations of what each pipeline does and what data it really depends on. Not all of the shared configuration is really used by all of the pipelines, that reference it.
…into markPodsDeployedByK8sCollector
3 participants
No description provided.