Skip to content

feat: vite preview #2060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
huseeiin wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: vite preview #2060

huseeiin wants to merge 8 commits into from
+17 −0

Conversation

@huseeiin
Copy link
Contributor

@huseeiin huseeiin commented Jan 29, 2026

add vite preview support 🎉

@changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: b9373f8

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jan 29, 2026 •
edited
Loading

✅ Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit b9373f8
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/6982ee91ea649400082afd15
😎 Deploy Preview https://deploy-preview-2060--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 29, 2026 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/start@2060

npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/vite-plugin-nitro-2@2060

commit: b9373f8

@huseeiin huseeiin marked this pull request as draft January 29, 2026 13:47
@huseeiin huseeiin marked this pull request as ready for review January 29, 2026 13:52
@huseeiin huseeiin marked this pull request as draft January 29, 2026 14:03
@huseeiin huseeiin marked this pull request as ready for review January 29, 2026 14:11
@brenelz
Copy link
Contributor

brenelz commented Feb 4, 2026

Why are all our checks failing on this pr?

brenelz
brenelz reviewed Feb 4, 2026
View reviewed changes
packages/start/src/config/dev-server.ts
return [
{
name: "solid-start-dev-server",
configurePreviewServer(server) {
Copy link
Contributor

@brenelz brenelz Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@birkskyum does this seem reasonable?

@huseeiin
Copy link
Contributor Author

huseeiin commented Feb 4, 2026 •
edited
Loading

Why are all our checks failing on this pr?

because i did globalThis.CAN_SEND_FAST_NODE_STREAMS = true which is a type that doesn't exist, but i learned its not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brenelz brenelz brenelz left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@huseeiin @brenelz