Skip to content

Conversation

@lxsmnsyc
Copy link
Member

@lxsmnsyc lxsmnsyc commented Feb 3, 2026

Current header value for x-server-id uses a # which is reserved. We have to use percent encoding.

@netlify
Copy link

netlify bot commented Feb 3, 2026

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit cb39a7f
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/69818db2efe2dd0008491773
😎 Deploy Preview https://deploy-preview-2061--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2026

⚠️ No Changeset found

Latest commit: cb39a7f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 3, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@solidjs/start@2061

commit: cb39a7f

Copy link
Contributor

@brenelz brenelz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. Do we need to do this in the new version as well?

@lxsmnsyc
Copy link
Member Author

lxsmnsyc commented Feb 4, 2026

Seems reasonable to me. Do we need to do this in the new version as well?

no, 2.x uses a hash, so not much of an issue atm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants